Fix the value validation for Int/Float attributes with expressions
#2885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2885 +/- ##
========================================
Coverage 79.02% 79.02%
========================================
Files 51 51
Lines 6856 6856
========================================
Hits 5418 5418
Misses 1438 1438 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbentejac
changed the title
Int/Float attributes' validation on values for expressions
cbentejac
changed the title
Int/Float attributes' validation on values for expressionsInt/Float attributes with expressions
cbentejac
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue with IntParam/FloatParam value validation
In #2836 we introduced a system to evaluate expressions in int/float fields, however the way it was implemented broke the value validation on attributes on the python side.
With this PR the issue is solved however we loose undostack on wrong expressions